Skip to content

build: Extract prettier into main package.json #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

AbhiPrasad
Copy link
Member

Similar motivation #4236

As prep for unifying our package.json, let's move dependencies that every package uses into the root package.json.

This patch does that for the prettier package.

Decided against bumping prettier, as we would go to Prettier v2, which has way more changes. We'll need to get there eventually though.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

size-limit report

Path Base Size (cefc919) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 22.45 KB 22.45 KB +0.02% 🔺
@sentry/browser - Webpack 23.29 KB 23.29 KB 0%
@sentry/react - Webpack 23.32 KB 23.32 KB 0%
@sentry/nextjs Client - Webpack 47.98 KB 47.98 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.9 KB 29.9 KB +0.01% 🔺

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 6, 2021 15:40
@AbhiPrasad AbhiPrasad merged commit 59f74b7 into master Dec 6, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-prettier-bump branch December 6, 2021 15:51
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
As prep for unifying our package.json, let's move dependencies that every package uses into the root `package.json`.

This patch does that for the `prettier` package.

Decided against bumping prettier, as we would go to [Prettier v2](https://prettier.io/blog/2020/03/21/2.0.0.html), which has way more changes. We'll need to get there eventually though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants